Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] Add network type option for Host checkout #16682

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #16639

Problem Statement

Host checkout failing for IPv6 because we are missing parameter "deploy_network_type" while checking out host.

Solution

Added parameter "deploy_network_type" while host checkout.

Related Issues

@Satellite-QE Satellite-QE added the 6.15.z Introduced in or relating directly to Satellite 6.15 label Oct 16, 2024
@Satellite-QE Satellite-QE requested a review from a team as a code owner October 16, 2024 07:31
@Satellite-QE Satellite-QE added Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Oct 16, 2024
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py tests/foreman/ui/test_errata.py -k 'test_positive_leapp_upgrade_rhel or test_positive_apply_for_all_hosts'

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 8973
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py tests/foreman/ui/test_errata.py -k test_positive_leapp_upgrade_rhel or test_positive_apply_for_all_hosts --external-logging
Test Result : ========== 1 failed, 19 deselected, 48 warnings in 1038.48s (0:17:18) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 16, 2024
@shweta83
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py tests/foreman/ui/test_errata.py -k 'test_positive_leapp_upgrade_rhel or test_positive_apply_for_all_hosts'

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 8977
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py tests/foreman/ui/test_errata.py -k test_positive_leapp_upgrade_rhel or test_positive_apply_for_all_hosts --external-logging
Test Result : ========== 1 failed, 19 deselected, 48 warnings in 1024.49s (0:17:04) ==========

@Gauravtalreja1
Copy link
Collaborator

@shweta83 Could you investigate the failures, and update the PR?

@shweta83 shweta83 marked this pull request as draft November 19, 2024 09:48
Add network type option for Host checkout

(cherry picked from commit 6eb87cc)
@shweta83 shweta83 force-pushed the cherry-pick-6.15.z-6eb87cc60ddcb0c765f8c3b88888c761d9cc2be8 branch from 4593736 to 244e8f0 Compare January 3, 2025 06:28
@shweta83
Copy link
Contributor

shweta83 commented Jan 3, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py tests/foreman/ui/test_errata.py -k 'test_positive_leapp_upgrade_rhel or test_positive_apply_for_all_hosts'

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9740
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py tests/foreman/ui/test_errata.py -k test_positive_leapp_upgrade_rhel or test_positive_apply_for_all_hosts --external-logging
Test Result : ========== 1 failed, 19 deselected, 48 warnings in 1163.96s (0:19:23) ==========

@shweta83
Copy link
Contributor

shweta83 commented Jan 3, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9741
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py --external-logging
Test Result : ============ 1 passed, 114 warnings, 1 error in 3389.12s (0:56:29) =============

@shweta83 shweta83 marked this pull request as ready for review January 3, 2025 08:09
@shweta83
Copy link
Contributor

shweta83 commented Jan 3, 2025

The changes work and the failure is unrelated to the current changes.

@shweta83 shweta83 requested a review from a team January 3, 2025 08:11
Copy link
Contributor

@amolpati30 amolpati30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shweta83 Yes, your changes to the fixture 'custom_leapp_host' are working. However, it is failing in another fixture 'verify_target_repo_on_satellite'. If you can resolve that, it’s up to you. In the meantime, this PR looks good to me. Acknowledged.

@Gauravtalreja1 Gauravtalreja1 merged commit 8064dcc into 6.15.z Jan 3, 2025
10 of 11 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.15.z-6eb87cc60ddcb0c765f8c3b88888c761d9cc2be8 branch January 3, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants