Add entities.PartitionTable.update() #132
Conversation
| @@ -2774,6 +2778,17 @@ def __init__(self, server_config=None, **kwargs): | |||
| self._meta = {'api_path': 'api/v2/ptables', 'server_modes': ('sat')} | |||
| super(PartitionTable, self).__init__(server_config, **kwargs) | |||
|
|
|||
| def update(self, fields=None): | |||
| """Fetch a complete set of attributes for this entity.""" | |||
There was a problem hiding this comment.
Is there a bugzilla bug stating what's wrong? If not, can we make one? And if so, can we link to it?
My goal is to make sure that every single work-around in NailGun is associated with a bug, even when that means filing trivial bugs or bugs against old versions of Satellite. I'm tracking progress in #115. Feel free to add this method to that list. (Some examples of bugs)
There was a problem hiding this comment.
Oops, my bad. Double checked - everything works just fine without any workarounds.
API has confusing behavior sometimes - some entities require extra dict, some - don't, and some are working ok both with and without it.
I'll remove update() and update_payload(). @Ichimonji10 , should i remove the tests as well? I can't see any tests for entities-with-no-workarounds.
There was a problem hiding this comment.
API has confusing behavior sometimes - some entities require extra dict, some - don't, and some are working ok both with and without it.
Yeah. It's a real bugger.
Yes, please do remove the tests from test_entities.py as well.
Added ```entities.PartitionTable.update()```, as it's needed for SatelliteQE/robottelo#2502. Part of SatelliteQE#111.
|
ACK |
1 similar comment
|
ACK |
Add entities.PartitionTable.update()
|
👍 |
Added
entities.PartitionTable.update(), as it's needed for SatelliteQE/robottelo#2502.Part of #111.