Add initial attempts to automatically clean up dangling hosts #337
+107
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (2)
broker/providers/ansible_tower.py:381
- Check for the existence of 'node.summary_fields["job"]' and 'node.summary_fields["job"]["failed"]' before accessing them to avoid potential KeyError.
if node.summary_fields["job"]["failed"]:
broker/providers/ansible_tower.py:388
- Ensure that 'job' is not None before proceeding to avoid potential AttributeError.
def _try_checkin_dangling_host(self, job):
JacobCallahan
force-pushed
the
cleanup
branch
3 times, most recently
from
ed68222 to
6d65d28
Compare
JacobCallahan
force-pushed
the
cleanup
branch
2 times, most recently
from
47c310f to
17b419f
Compare
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
broker/config_manager.py:102
- The condition 'and "example" not in module.name' could be more specific to avoid false positives.
if hasattr(module, "run_migrations") and "example" not in module.__name__:
17b419f to
8c7ce23
Compare
Now, when workflows fail, Broker will attempt to find a handgling host and check it in if found.
JacobCallahan
force-pushed
the
cleanup
branch
from
8c7ce23 to
e46159d
Compare
ogajduse
reviewed
Dec 5, 2024
| @@ -127,6 +128,7 @@ class AnsibleTower(Provider): | |||
| | Validator("ANSIBLETOWER.token", must_exist=True) | |||
| ), | |||
| Validator("ANSIBLETOWER.inventory", default=None), | |||
| Validator("ANSIBLETOWER.dangling_behavior", default="checkin"), | |||
There was a problem hiding this comment.
Suggested change
| Validator("ANSIBLETOWER.dangling_behavior", default="checkin"), | |
| Validator("ANSIBLETOWER.dangling_behavior", default="checkin", is_in=["prompt", "checkin", "store"]), |
| logger.debug(f"Storing dangling host: {dangling_host}") | ||
| host = self._v2.hosts.get(name=dangling_host).results[0] | ||
| host = self._compile_host_info(host) | ||
| host["failed"] = True |
There was a problem hiding this comment.
Suggested change
| host["failed"] = True | |
| host["deploy_failed"] = True |
I prefer to be a bit more explicit about what failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, when workflows fail, Broker will attempt to find a dangling host and check it in if found.