fix: start tour messages are attached to proper location now #387
Conversation
|
@Amitooo1 is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughIn this update, key changes involve modifying the Changes
Sequence Diagram(s)Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @Amitooo1! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!
'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
src/components/core/navbar/index.tsx (1)
Line range hint
131-136: Add explicittypeattributes to the button elements to prevent unintended form submissions.- <button onClick={() => setMenuOpen(!isMenuOpen)} className={`...`}> + <button type="button" onClick={() => setMenuOpen(!isMenuOpen)} className={`...`}> - <button onClick={() => setMenuOpen(!isMenuOpen)} className={`...`}> + <button type="button" onClick={() => setMenuOpen(!isMenuOpen)} className={`...`}>Also applies to: 216-221
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- src/components/core/navbar/index.tsx (2 hunks)
- src/components/pages/home/index.tsx (1 hunks)
- src/helper/startTour.ts (2 hunks)
Files skipped from review due to trivial changes (1)
- src/components/pages/home/index.tsx
Additional context used
Biome
src/components/core/navbar/index.tsx
[error] 131-136: Provide an explicit type prop for the button element. (lint/a11y/useButtonType)
The default type of a button is submit, which causes the submission of a form when placed inside a
formelement. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
[error] 216-221: Provide an explicit type prop for the button element. (lint/a11y/useButtonType)
The default type of a button is submit, which causes the submission of a form when placed inside a
formelement. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
Additional comments not posted (3)
src/helper/startTour.ts (1)
38-38: Updated tour step targets and positions align with the PR's objectives and should improve user experience by ensuring the tour messages are attached to more accurate locations.Also applies to: 102-103
src/components/core/navbar/index.tsx (2)
127-127: Added anidattribute to improve element targeting for the tour. This change supports the PR's goal to align tour popups correctly.
143-145: The new wrappingdivwith anidof "theme" around theThemeButtonis consistent with the changes made to improve tour element targeting.
Sanchitbajaj02
added
🪲 bug
fixes #357
Description
Start tour popups are now aligned properly to a more accurate location.
Screenshots
Summary by CodeRabbit