Memory stack #288
Merged
Memory stack #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
memory_stack
branch
3 times, most recently
from
d6d7fc2
to
9883c3a
Compare
Create the cache only when necessary. Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
memory_stack
branch
from
9883c3a
to
8db14c0
Compare
|
Patch is ready for review |
|
Although this patch is not relevant to it, but I wonder that if we are going to support multiple memories this caching strategy would be valid or easily updated for it? |
|
To tell you the truth, I plan to rework this whole caching after #289, where I will remove most of these changes. However, I cannot do that in one step. The caching should be done by the Instance after that point. This will work well for multi memory, and the caching overhead will be smaller. Using the instance pointer, I can directly access the cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the only option to do this. If we could store the instance in a register (my long term plan), we could cache the memory in the instance. Then saving/restoring would be unnecessary.