Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jit threading #273

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Jit threading #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions src/jit/ByteCodeParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1899,6 +1899,62 @@ static void compileFunction(JITCompiler* compiler)
#endif /* SLJIT_CONFIG_X86 */
break;
}
#if defined(ENABLE_EXTENDED_FEATURES)
case ByteCode::I32AtomicLoadOpcode:
case ByteCode::I32AtomicLoad8UOpcode:
case ByteCode::I32AtomicLoad16UOpcode: {
info = Instruction::kIs32Bit;
requiredInit = OTLoadI32;
FALLTHROUGH;
}
case ByteCode::I64AtomicLoadOpcode:
case ByteCode::I64AtomicLoad8UOpcode:
case ByteCode::I64AtomicLoad16UOpcode:
case ByteCode::I64AtomicLoad32UOpcode: {
Instruction* instr = compiler->append(byteCode, Instruction::Load, opcode, 1, 1);
#if (defined SLJIT_32BIT_ARCHITECTURE && SLJIT_32BIT_ARCHITECTURE)
if (opcode == ByteCode::I64AtomicLoadOpcode) {
info = Instruction::kIsCallback;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only I64AtomicLoadOpcode needs a callback. The rest stores <= 32 bit, so they are supported on 32 bit systems.

#endif /* SLJIT_32BIT_ARCHITECTURE */
instr->addInfo(info);
instr->setRequiredRegsDescriptor(requiredInit != OTNone ? requiredInit : OTLoadI64);

MemoryLoad* loadOperation = reinterpret_cast<MemoryLoad*>(byteCode);
Operand* operands = instr->operands();

operands[0] = STACK_OFFSET(loadOperation->srcOffset());
operands[1] = STACK_OFFSET(loadOperation->dstOffset());
break;
}
case ByteCode::I32AtomicStoreOpcode:
case ByteCode::I32AtomicStore8Opcode:
case ByteCode::I32AtomicStore16Opcode: {
info = Instruction::kIs32Bit;
requiredInit = OTStoreI32;
FALLTHROUGH;
}
case ByteCode::I64AtomicStoreOpcode:
case ByteCode::I64AtomicStore8Opcode:
case ByteCode::I64AtomicStore16Opcode:
case ByteCode::I64AtomicStore32Opcode: {
Instruction* instr = compiler->append(byteCode, Instruction::Store, opcode, 2, 0);
#if (defined SLJIT_32BIT_ARCHITECTURE && SLJIT_32BIT_ARCHITECTURE)
if (opcode == ByteCode::I64AtomicStoreOpcode) {
info = Instruction::kIsCallback;
}
#endif /* SLJIT_32BIT_ARCHITECTURE */
instr->addInfo(info);
instr->setRequiredRegsDescriptor(requiredInit != OTNone ? requiredInit : OTStoreI64);

MemoryStore* atomicStore = reinterpret_cast<MemoryStore*>(byteCode);
Operand* operands = instr->operands();

operands[0] = STACK_OFFSET(atomicStore->src0Offset());
operands[1] = STACK_OFFSET(atomicStore->src1Offset());
break;
}
#endif /* ENABLE_EXTENDED_FEATURES */
default: {
ASSERT_NOT_REACHED();
break;
Expand Down
Loading
Loading