Added symbols loading when loading in-memory modules #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viewizard
requested changes
Feb 17, 2024
viewizard
reviewed
Feb 17, 2024
|
Looks good for me. We move this PR into internal dev repo for more testing with internal CI, this will take some time (have a lot of work now). Will be in next repo sync in upstream. |
viewizard
reviewed
Feb 18, 2024
|
I moved this PR into dev repo, all tests passed in CI, waiting for approvals and merge into dev repo now. |
|
Thanks for your contribution, fix is part of latest release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modification of PR #108 that only deals with symbol loading when loading in-memory modules.
This might fix related issues
#34
#91
It at least fixes my issue with Godot symbols not being loaded.