-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Modify exceptions #6355
Merged
Merged
[Core] Modify exceptions #6355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some methods should throw InvalidOperationException. This patch modifies that. Signed-off-by: Hwankyu Jhun <[email protected]>
Signed-off-by: Hwankyu Jhun <[email protected]>
Signed-off-by: Hwankyu Jhun <[email protected]>
Signed-off-by: Hwankyu Jhun <[email protected]>
Signed-off-by: Hwankyu Jhun <[email protected]>
Signed-off-by: Hwankyu Jhun <[email protected]>
upple
reviewed
Sep 25, 2024
src/Tizen.Core/Tizen.Core/Task.cs
Outdated
TCoreErrorFactory.CheckAndThrownException(error, "Failed to quit task"); | ||
if (error != Interop.LibTizenCore.ErrorCode.None) | ||
{ | ||
throw new InvalidOperationException("Failed to run task"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to be modified.
Suggested change
throw new InvalidOperationException("Failed to run task"); | |
throw new InvalidOperationException("Failed to quit task"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Hwankyu Jhun <[email protected]>
upple
approved these changes
Sep 25, 2024
Signed-off-by: Hwankyu Jhun <[email protected]>
hjhun
force-pushed
the
ModifyTizenCoreException
branch
from
September 25, 2024 06:57
d556331
to
6e9d1f0
Compare
bshsqa
pushed a commit
to bshsqa/TizenFX
that referenced
this pull request
Sep 25, 2024
* [Core] Modify exceptions Some methods should throw InvalidOperationException. This patch modifies that. Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Add a missing exception to ChannelReceiver.Receive() Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Fix ambiguous error messages Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Fix wrong description & implementation Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Modify ambiguous log message Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Convert error to C# exception Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Fix wrong log message Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Fix wrong error handling Signed-off-by: Hwankyu Jhun <[email protected]> --------- Signed-off-by: Hwankyu Jhun <[email protected]>
bshsqa
pushed a commit
that referenced
this pull request
Sep 25, 2024
* [Core] Modify exceptions Some methods should throw InvalidOperationException. This patch modifies that. Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Add a missing exception to ChannelReceiver.Receive() Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Fix ambiguous error messages Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Fix wrong description & implementation Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Modify ambiguous log message Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Convert error to C# exception Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Fix wrong log message Signed-off-by: Hwankyu Jhun <[email protected]> * [Core] Fix wrong error handling Signed-off-by: Hwankyu Jhun <[email protected]> --------- Signed-off-by: Hwankyu Jhun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request modifies the descriptions and codes of methods as follows: