[NUI] Support ImageView and ImageVisual the SamplingMode #6345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinohie
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
rabbitfor
as code owners
Internal API ChangedAdded: 4, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.SamplingModeType Tizen.NUI.BaseComponents.ImageView::SamplingMode()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.SamplingModeType Tizen.NUI.SamplingModeType::BoxThenIntegrate
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.SamplingModeType Tizen.NUI.SamplingModeType::Integrate
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.SamplingModeType Tizen.NUI.Visuals.ImageVisual::SamplingMode()
|
hinohie
force-pushed
the
add_sampling_mode
branch
from
8744d34
to
05247d1
Compare
Internal API ChangedAdded: 4, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.SamplingModeType Tizen.NUI.BaseComponents.ImageView::SamplingMode()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.SamplingModeType Tizen.NUI.SamplingModeType::BoxThenSinc
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.SamplingModeType Tizen.NUI.SamplingModeType::Sinc
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.SamplingModeType Tizen.NUI.Visuals.ImageVisual::SamplingMode()
|
Seoyeon2Kim
approved these changes
Sep 24, 2024
rabbitfor
reviewed
Sep 24, 2024
hinohie
force-pushed
the
add_sampling_mode
branch
from
05247d1
to
7bdbe0a
Compare
Internal API ChangedAdded: 4, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.SamplingModeType Tizen.NUI.BaseComponents.ImageView::SamplingMode()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.SamplingModeType Tizen.NUI.SamplingModeType::BoxThenLanczos
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.SamplingModeType Tizen.NUI.SamplingModeType::Lanczos
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.SamplingModeType Tizen.NUI.Visuals.ImageVisual::SamplingMode()
|
hinohie
force-pushed
the
add_sampling_mode
branch
from
7bdbe0a
to
a3a3f76
Compare
Let we add property for change sampling mode when we change desired size of given image. Relative dali patch https://review.tizen.org/gerrit/c/platform/core/uifw/dali-core/+/317969 https://review.tizen.org/gerrit/c/platform/core/uifw/dali-adaptor/+/317993 https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/317992 https://review.tizen.org/gerrit/c/platform/core/uifw/dali-demo/+/318001 Signed-off-by: Eunki, Hong <[email protected]>
hinohie
force-pushed
the
add_sampling_mode
branch
from
a3a3f76
to
fa75b0f
Compare
Internal API ChangedAdded: 4, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.SamplingModeType Tizen.NUI.BaseComponents.ImageView::SamplingMode()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.SamplingModeType Tizen.NUI.SamplingModeType::BoxThenLanczos
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.SamplingModeType Tizen.NUI.SamplingModeType::Lanczos
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.SamplingModeType Tizen.NUI.Visuals.ImageVisual::SamplingMode()
|
rabbitfor
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let we add property for change sampling mode when we change
desired size of given image.
Relative dali patch :
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-core/+/317969
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-adaptor/+/317993
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/317992
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-demo/+/318001