Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Add comments (2nd patch) #6339

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

dongsug-song
Copy link
Contributor

@dongsug-song dongsug-song commented Sep 20, 2024

Description of Change

[NUI] Add comments (2nd patch)

TizenFX/src/Tizen.NUI/src/public/Animation/Path.cs => 7 changes
TizenFX/src/Tizen.NUI/src/public/Animation/TransitionOptions.cs => 1 change
TizenFX/src/Tizen.NUI/src/public/Application/NUIApplication.cs => 23 changes
TizenFX/src/Tizen.NUI/src/public/Application/NUIWidgetApplication.cs => 10 changes
TizenFX/src/Tizen.NUI/src/public/Application/WatchTime.cs => will be deprecated
TizenFX/src/Tizen.NUI/src/public/ApplicationAnimation/ApplicationTransitionManager.cs =>
The 'ApplicationTransitionManager' class was originally a hidden API, and the 'Instance' API was also a hidden API, but it seems that the hidden API attribute was accidentally not applied. Therefore, it does not fall under the ACR case.
TizenFX/src/Tizen.NUI/src/public/BaseComponents/Style/Selector.cs => 8 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/Style/ViewStyle.cs => 15 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/VectorGraphics/ColorStop.cs => 3 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/VectorGraphics/PathCommands.cs => 2 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/VectorGraphics/Picture.cs => 1 change
TizenFX/src/Tizen.NUI/src/public/BaseComponents/VectorGraphics/Shape.cs => 2 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/CameraView.cs => 2 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/LottieAnimationView.cs => 6 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TableView.cs => 10 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TextEditor.cs => 5 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TextEditorEvent.cs => 3 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TextField.cs => 8 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TextFieldEvent.cs => 4 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TextLabel.cs => 8 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/VideoView.cs => 1 change
TizenFX/src/Tizen.NUI/src/public/BaseComponents/View.cs => 16 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/ViewPublicMethods.cs => 13 changes

API Changes

nothing

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 0, Removed: 0, Changed: 5

Changed

- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean Tizen.NUI.BaseComponents.Selector`1::GetValue(Tizen.NUI.BaseComponents.ControlState,T&)

- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
Tizen.NUI.BaseComponents.Selector`1<T> Tizen.NUI.BaseComponents.Selector`1::Clone()

- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.NUIApplication/WindowMode,Tizen.NUI.Size2D,Tizen.NUI.Position2D)

- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.Size2D,Tizen.NUI.Position2D)

- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.Size2D,Tizen.NUI.Position2D)

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 0, Removed: 0, Changed: 5

Changed

- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean Tizen.NUI.BaseComponents.Selector`1::GetValue(Tizen.NUI.BaseComponents.ControlState,T&)

- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
Tizen.NUI.BaseComponents.Selector`1<T> Tizen.NUI.BaseComponents.Selector`1::Clone()

- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.NUIApplication/WindowMode,Tizen.NUI.Size2D,Tizen.NUI.Position2D)

- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.Size2D,Tizen.NUI.Position2D)

- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.Size2D,Tizen.NUI.Position2D)

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 0, Removed: 0, Changed: 5

Changed

- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean Tizen.NUI.BaseComponents.Selector`1::GetValue(Tizen.NUI.BaseComponents.ControlState,T&)

- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
Tizen.NUI.BaseComponents.Selector`1<T> Tizen.NUI.BaseComponents.Selector`1::Clone()

- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.NUIApplication/WindowMode,Tizen.NUI.Size2D,Tizen.NUI.Position2D)

- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.Size2D,Tizen.NUI.Position2D)

- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.Size2D,Tizen.NUI.Position2D)

Copy link
Contributor

@hinohie hinohie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dongsug-song dongsug-song merged commit 29b2c1b into Samsung:DevelNUI Sep 25, 2024
3 checks passed
@dongsug-song dongsug-song deleted the addComment0920 branch September 25, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants