-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Add comments (2nd patch) #6339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal API ChangedAdded: 0, Removed: 0, Changed: 5Changed- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean Tizen.NUI.BaseComponents.Selector`1::GetValue(Tizen.NUI.BaseComponents.ControlState,T&)
- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
Tizen.NUI.BaseComponents.Selector`1<T> Tizen.NUI.BaseComponents.Selector`1::Clone()
- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.NUIApplication/WindowMode,Tizen.NUI.Size2D,Tizen.NUI.Position2D)
- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.Size2D,Tizen.NUI.Position2D)
- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.Size2D,Tizen.NUI.Position2D)
|
dongsug-song
force-pushed
the
addComment0920
branch
from
September 23, 2024 13:57
5a95705
to
3641fb3
Compare
Internal API ChangedAdded: 0, Removed: 0, Changed: 5Changed- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean Tizen.NUI.BaseComponents.Selector`1::GetValue(Tizen.NUI.BaseComponents.ControlState,T&)
- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
Tizen.NUI.BaseComponents.Selector`1<T> Tizen.NUI.BaseComponents.Selector`1::Clone()
- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.NUIApplication/WindowMode,Tizen.NUI.Size2D,Tizen.NUI.Position2D)
- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.Size2D,Tizen.NUI.Position2D)
- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.Size2D,Tizen.NUI.Position2D)
|
dongsug-song
force-pushed
the
addComment0920
branch
from
September 24, 2024 13:58
3641fb3
to
e52150b
Compare
dongsug-song
requested review from
wonrst,
hyunjushin,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
September 24, 2024 14:00
Internal API ChangedAdded: 0, Removed: 0, Changed: 5Changed- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean Tizen.NUI.BaseComponents.Selector`1::GetValue(Tizen.NUI.BaseComponents.ControlState,T&)
- /// <since_tizen>6</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
Tizen.NUI.BaseComponents.Selector`1<T> Tizen.NUI.BaseComponents.Selector`1::Clone()
- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.NUIApplication/WindowMode,Tizen.NUI.Size2D,Tizen.NUI.Position2D)
- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(System.String,Tizen.NUI.Size2D,Tizen.NUI.Position2D)
- /// <since_tizen>5</since_tizen
+ /// <since_tizen>none</since_tizen
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.NUI.NUIApplication::.ctor(Tizen.NUI.Size2D,Tizen.NUI.Position2D)
|
rabbitfor
approved these changes
Sep 25, 2024
hinohie
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
hyunjushin
approved these changes
Sep 25, 2024
JoogabYun
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[NUI] Add comments (2nd patch)
TizenFX/src/Tizen.NUI/src/public/Animation/Path.cs => 7 changes
TizenFX/src/Tizen.NUI/src/public/Animation/TransitionOptions.cs => 1 change
TizenFX/src/Tizen.NUI/src/public/Application/NUIApplication.cs => 23 changes
TizenFX/src/Tizen.NUI/src/public/Application/NUIWidgetApplication.cs => 10 changes
TizenFX/src/Tizen.NUI/src/public/Application/WatchTime.cs => will be deprecated
TizenFX/src/Tizen.NUI/src/public/ApplicationAnimation/ApplicationTransitionManager.cs =>
The 'ApplicationTransitionManager' class was originally a hidden API, and the 'Instance' API was also a hidden API, but it seems that the hidden API attribute was accidentally not applied. Therefore, it does not fall under the ACR case.
TizenFX/src/Tizen.NUI/src/public/BaseComponents/Style/Selector.cs => 8 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/Style/ViewStyle.cs => 15 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/VectorGraphics/ColorStop.cs => 3 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/VectorGraphics/PathCommands.cs => 2 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/VectorGraphics/Picture.cs => 1 change
TizenFX/src/Tizen.NUI/src/public/BaseComponents/VectorGraphics/Shape.cs => 2 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/CameraView.cs => 2 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/LottieAnimationView.cs => 6 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TableView.cs => 10 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TextEditor.cs => 5 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TextEditorEvent.cs => 3 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TextField.cs => 8 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TextFieldEvent.cs => 4 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/TextLabel.cs => 8 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/VideoView.cs => 1 change
TizenFX/src/Tizen.NUI/src/public/BaseComponents/View.cs => 16 changes
TizenFX/src/Tizen.NUI/src/public/BaseComponents/ViewPublicMethods.cs => 13 changes
API Changes
nothing