Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase DevelNUI to master #5385

Merged
merged 6 commits into from
Jul 11, 2023
Merged

Rebase DevelNUI to master #5385

merged 6 commits into from
Jul 11, 2023

Conversation

huiyueun
Copy link
Contributor

Description of Change

API Changes

  • ACR:

Seoyeon2Kim and others added 6 commits July 11, 2023 14:39
@Seoyeon2Kim @huiyueun
[NUI] Update FontSizeScale values
9f19e6f 
- Except for TV and wearable profiles, FontSizeScale values are updated.

Signed-off-by: Seoyeon Kim <[email protected]>
@tscholb @huiyueun
[NUI] Delete the used window in widget
b8e52c7 
Delete the used window so that the window can be deleted normally when deleting the widget.
this is for memory leak issue.
@JoogabYun @huiyueun
[NUI] Binding IsFloatingModeEnabled()
4dcac5b 
refer :
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/295493/
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/295494/
@JoogabYun @huiyueun
[NUI] Register OrientationChanged for BorderWindow.
0ab1851 
Because if the window is rotated, we need to resize the window by recalculating the border area.
@Jaehyun-Cho @huiyueun
[NUI] Fix not to propagate gesture from scrim
2e86c5a 
Scrim should block all touch and gesture events.
Therefore, gesture is also not propagated from scrim.
@huiyueun
Version update - 22234
cac4568 
Signed-off-by: huiyu <[email protected]>
@github-actions github-actions bot added the API11 Platform : Tizen 8.0 / TFM: net6.0-tizen8.0 label Jul 11, 2023
jaehyun0cho
jaehyun0cho approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@jaehyun0cho jaehyun0cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 1, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Window::IsFloatingModeEnabled()

@huiyueun huiyueun merged commit 31f7768 into Samsung:master Jul 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaehyun0cho jaehyun0cho jaehyun0cho approved these changes

@wonrst wonrst Awaiting requested review from wonrst wonrst is a code owner

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@dongsug-song dongsug-song Awaiting requested review from dongsug-song dongsug-song is a code owner

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim Seoyeon2Kim is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@everLEEst everLEEst Awaiting requested review from everLEEst everLEEst is a code owner

@rabbitfor rabbitfor Awaiting requested review from rabbitfor rabbitfor is a code owner

@hinohie hinohie Awaiting requested review from hinohie hinohie is a code owner

Assignees
No one assigned
Labels
API11 Platform : Tizen 8.0 / TFM: net6.0-tizen8.0 Internal API Changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@huiyueun @TizenAPI-Bot @jaehyun0cho @Seoyeon2Kim @tscholb @JoogabYun @Jaehyun-Cho