1610 implement put for interview notes #1651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemisis84
commented
Dec 21, 2024
| @@ -1060,6 +1060,7 @@ class RecruitmentApplicationForRecruiterSerializer(serializers.ModelSerializer): | |||
| recruitment_position = RecruitmentPositionForApplicantSerializer() | |||
| recruiter_priority = serializers.CharField(source='get_recruiter_priority_display') | |||
| interview_time = serializers.SerializerMethodField(method_name='get_interview_time', read_only=True) | |||
| interview = InterviewSerializer(read_only=True) | |||
There was a problem hiding this comment.
We needed to add the interview object to the serializer. Could potentially limit this to only id and notes.
nemisis84
commented
Dec 21, 2024
| interview.notes = update_serializer.validated_data['notes'] | ||
| interview.save() | ||
| return Response(status=status.HTTP_200_OK) | ||
| return Response(update_serializer.errors, status=status.HTTP_400_BAD_REQUEST) |
There was a problem hiding this comment.
I did not include any data in the successful response as the user already has the live changes.
nemisis84
commented
Dec 21, 2024
| @@ -84,6 +87,11 @@ export function RecruitmentApplicantAdminPage() { | |||
| </Text> | |||
| <Text>{recruitmentApplication?.application_text}</Text> | |||
| </div> | |||
| {interviewId && ( | |||
There was a problem hiding this comment.
If interviewId excist then show this div
nemisis84
commented
Dec 21, 2024
| // TODO: Update notes using a put request | ||
| console.log(value); | ||
| } | ||
| const handleNotesChange = (newNotes: string) => { |
There was a problem hiding this comment.
Helper method to check if any changes was made. If no changes was made, but onBlur was triggered, we don't need to send a put request
nemisis84
requested review from
Mathias-a,
robines and
Snorre98
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admins can take notes for candidates. Stored in field "notes" in object Interview. There are only possible to take notes when an interview is made. An interview is made once a time for the interview is set. In the future we could explore making the interview once an application is made or at another point of time.