Add dropdown to recruitment header #1629
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snorre98
reviewed
Dec 10, 2024
Comment on lines
114
to
130
| const recruitmentLinks = showActiveRecruitments && ( | ||
| <> | ||
| {activeRecruitments?.map((recruitment) => ( | ||
| <Link | ||
| key={recruitment.id} | ||
| url={reverse({ | ||
| pattern: ROUTES.frontend.organization_recruitment, | ||
| urlParams: { recruitmentId: recruitment?.id }, | ||
| })} | ||
| className={styles.navbar_dropdown_link} | ||
| onAfterClick={() => setExpandedDropdown('')} | ||
| > | ||
| {dbT(recruitment, 'name')} {recruitment.organization.toString()} | ||
| </Link> | ||
| ))} | ||
| </> | ||
| ); |
There was a problem hiding this comment.
Lag en egen PR på dropdown links for opptak. Det er ikke sikkert vi skal vise flere pågående opptak på samme side. Sannsynligvis skal vi ha et "hovedopptak" som vises når man går til /recruitment. Andre opptak skal sannsynligvis kun promoteres fra UKA/ISFiT sin nettside
There was a problem hiding this comment.
^
Tror ikke vi burde fremheve alle opptak uten å bli enige med UKA, ISFiT og Samf om hvordan det skal gjøres
|
Endrer denne til draft fordi det ikke er sikkert det skal være mulig å navigere til ISFiT/UKA opptak gjennom UI på sm.no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header would still show active recruitment even with no active recruitment