Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1369 bug incorrect applicant status behavior #1510

Merged
merged 9 commits into from
Oct 22, 2024
Merged

1369 bug incorrect applicant status behavior #1510

merged 9 commits into from
Oct 22, 2024

Conversation

simensee
Copy link
Contributor

@simensee simensee commented Oct 3, 2024

Changes:

  • Fix bug where next application in list get the same status as application set to "Called and rejected" when index is updated. Made Dropdown component controllable by using value instead of initialValue.
  • Add section for showing applicants that has rejected the offer for position.

@simensee simensee linked an issue Oct 3, 2024 that may be closed by this pull request
Bug: incorrect applicant status behavior #1369
Closed
@simensee
Copy link
Contributor Author

simensee commented Oct 3, 2024

Is fukked, will fix

@robines robines mentioned this pull request Oct 8, 2024
Merged
Snorre98
Snorre98 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Snorre98 Snorre98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Kan fikse noe greier med react hook form senere

@simensee simensee merged commit 986f5b3 into master Oct 22, 2024
5 checks passed
@simensee simensee deleted the 1369-bug-incorrect-applicant-status-behavior branch October 22, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snorre98 Snorre98 Snorre98 approved these changes

@Mathias-a Mathias-a Awaiting requested review from Mathias-a Mathias-a is a code owner

@robines robines Awaiting requested review from robines robines is a code owner

Assignees

@simensee simensee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: incorrect applicant status behavior
2 participants
@simensee @Snorre98