Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type field to AttributeAttribute #393

Merged

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Dec 13, 2024

The intention is for the Name field to be removed after Il2CppInterop switches to using the Type field.

@coveralls
Copy link

coveralls commented Dec 13, 2024

Pull Request Test Coverage Report for Build 12320749043

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 93 (3.23%) changed or added relevant lines in 7 files are covered.
  • 45 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.3%) to 27.79%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Cpp2IL.Core/Model/Contexts/ReferencedTypeAnalysisContext.cs 0 1 0.0%
Cpp2IL.Core/Utils/AttributeInjectionUtils.cs 0 2 0.0%
Cpp2IL.Core/ProcessingLayers/AttributeInjectorProcessingLayer.cs 0 5 0.0%
Cpp2IL.Core/Model/Contexts/TypeAnalysisContext.cs 0 9 0.0%
Cpp2IL.Core/Model/CustomAttributes/CustomAttributeTypeParameter.cs 3 14 21.43%
LibCpp2IL/LibCpp2IlUtils.cs 0 23 0.0%
Cpp2IL.Core/Model/Contexts/SystemTypesContext.cs 0 39 0.0%
Files with Coverage Reduction New Missed Lines %
LibCpp2IL/ReadableClass.cs 1 80.0%
Cpp2IL.Core/Model/CustomAttributes/CustomAttributeTypeParameter.cs 1 34.38%
Cpp2IL.Core/Utils/AsmResolver/AsmResolverUtils.cs 4 3.41%
LibCpp2IL/Metadata/Il2CppAssemblyNameDefinition.cs 39 17.43%
Totals Coverage Status
Change from base Build 12306846293: -0.3%
Covered Lines: 3386
Relevant Lines: 10377

💛 - Coveralls

@SamboyCoding
Copy link
Owner

This cannot be merged until https://github.com/BepInEx/Il2CppInterop/blob/9d4599dc78d69ede49a2ee96a1ccf41eec02db5b/Il2CppInterop.Generator/Passes/Pass70GenerateProperties.cs#L46 is changed and the change has time to be taken up by consumers.

@ds5678
Copy link
Contributor Author

ds5678 commented Dec 13, 2024

I added the name field back, so that this can be merged without breaking Il2CppInterop.

@ds5678 ds5678 changed the title Change AttributeAttribute Name field to a Type field Add Type field to AttributeAttribute Dec 13, 2024
@SamboyCoding SamboyCoding merged commit b9b8cca into SamboyCoding:development Dec 13, 2024
5 checks passed
@ds5678 ds5678 deleted the attributeattribute-type-field branch December 13, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants