Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set AssemblyDefinition::PublicKey when generating AsmResolver assemblies #390

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Dec 11, 2024

Not setting the PublicKey was causing AsmResolver.DotNet.Signatures.SignatureComparer to return false when comparing Mono methods and their corresponding Il2Cpp methods.

@coveralls
Copy link

coveralls commented Dec 11, 2024

Pull Request Test Coverage Report for Build 12284684366

Details

  • 1 of 12 (8.33%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 28.154%

Changes Missing Coverage Covered Lines Changed/Added Lines %
LibCpp2IL/ClassReadingBinaryReader.cs 1 2 50.0%
LibCpp2IL/Metadata/Il2CppAssemblyNameDefinition.cs 0 3 0.0%
LibCpp2IL/Metadata/Il2CppMetadata.cs 0 3 0.0%
Cpp2IL.Core/OutputFormats/AsmResolverDummyDllOutputFormat.cs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
Cpp2IL.Core/OutputFormats/AsmResolverDummyDllOutputFormat.cs 1 0.0%
Totals Coverage Status
Change from base Build 12223020379: -0.02%
Covered Lines: 3385
Relevant Lines: 10278

💛 - Coveralls

@SamboyCoding SamboyCoding merged commit 896d6c3 into SamboyCoding:development Dec 11, 2024
6 checks passed
@ds5678 ds5678 deleted the assembly-public-keys branch December 11, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants