Performance enhancements by using set not list, bugfix for explicit o…

…verrides
SamboyCoding · Oct 18, 2021 · 8df2dca · 8df2dca
1 parent 9f9f6cc
commit 8df2dca
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/Cpp2IL.Core/AssemblyPopulator.cs b/Cpp2IL.Core/AssemblyPopulator.cs
@@ -168,6 +168,10 @@ private static void FixupExplicitOverridesInType(TypeDefinition ilTypeDefinition
                         if (gParams.Length > 0)
                         {
                             var parameterRefs = gParams.Select(ResolveGenericParameter).ToArray();
+
+                            if (parameterRefs.Any(gp => gp == null))
+                                return null;
+
                             return ilTypeDefinition.Module.ImportRecursive(type.MakeGenericInstanceType(parameterRefs));
                         }
 

diff --git a/Cpp2IL.Core/Cpp2IlApi.cs b/Cpp2IL.Core/Cpp2IlApi.cs
@@ -246,7 +246,7 @@ public static void RunAttributeRestorationForAllAssemblies(BaseKeyFunctionAddres
         {
             CheckLibInitialized();
 
-            SharedState.AttributeGeneratorStarts = LibCpp2IlMain.Binary!.AllCustomAttributeGenerators.ToList();
+            LibCpp2IlMain.Binary!.AllCustomAttributeGenerators.ToList().ForEach(ptr => SharedState.AttributeGeneratorStarts.Add(ptr));
 
             var enumerable = (IEnumerable<AssemblyDefinition>) SharedState.AssemblyList;
 

diff --git a/Cpp2IL.Core/SharedState.cs b/Cpp2IL.Core/SharedState.cs
@@ -40,7 +40,7 @@ public static class SharedState
         internal static readonly List<AssemblyDefinition> AssemblyList = new List<AssemblyDefinition>();
         internal static readonly Dictionary<AssemblyDefinition, Il2CppImageDefinition> ManagedToUnmanagedAssemblies = new Dictionary<AssemblyDefinition, Il2CppImageDefinition>();
 
-        internal static List<ulong> AttributeGeneratorStarts = new();
+        internal static HashSet<ulong> AttributeGeneratorStarts = new();
 
         internal static void Clear()
         {