Fix:drewnoakes#640 Optimized formatHex method for efficiency and memo…

…ry usage
Salman-Sayyed · Dec 24, 2023 · 51b7b86 · 51b7b86
1 parent db9b141
commit 51b7b86
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/Source/com/drew/metadata/bmp/BmpHeaderDescriptor.java b/Source/com/drew/metadata/bmp/BmpHeaderDescriptor.java
@@ -143,7 +143,12 @@ public static String formatHex(@Nullable Long value, int digits) {
 
     @NotNull
     public static String formatHex(long value, int digits) {
-        return String.format("0x%0"+ digits + "X", value);
+        StringBuilder sb = new StringBuilder();
+        sb.append("0x");
+        long maskedValue = value & ((1L << (digits * 4)) - 1);
+        int leadingZeros = Long.numberOfLeadingZeros(maskedValue) >> 2; 
+        sb.append(Long.toHexString(maskedValue | (1L << (digits * 4))).substring(leadingZeros));
+        return sb.toString();
     }
 
     @Nullable