Fix buildVimPlugin #933
Merged
Fix buildVimPlugin #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flake lock file updates:
• Updated input 'nixpkgs':
'github:nixos/nixpkgs/4989a246d7a390a859852baddb1013f825435cee?narHash=sha256-kMBQ5PRiFLagltK0sH%2B08aiNt3zGERC2297iB6vrvlU%3D' (2024-12-17)
→ 'github:nixos/nixpkgs/b30f97d8c32d804d2d832ee837d0f1ca0695faa5?narHash=sha256-U47xeACNBpkSO6IcCm0XvahsVXpJXzjPIQG7TZlOToU%3D' (2025-01-06)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After NixOS/nixpkgs#352277 when we update nixpkgs in this repo - the plugin build fails with:
See: https://github.com/Saghen/blink.cmp/actions/runs/12654863130/job/35263764079?pr=933
Since this file is not needed for any release, we should simply ignore it from nvim sources instead of providing explicit require checks.
What we have here is:
The "update" step is optional, I just wanted to confirm that the build will fail and that this will fix it. If updating now is not preferred, we can remove that commit.
Note - we could also use
nvimSkipModuleto ignorereprobut I think we can just exclude it from source. However I'm open to suggestions.