fix lru cache expire #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekohasekai
force-pushed
the
dev
branch
2 times, most recently
from
02535f6
to
a74e3a1
Compare
nekohasekai
force-pushed
the
dev
branch
8 times, most recently
from
76e2ce0
to
2fa0399
Compare
nekohasekai
force-pushed
the
dev
branch
3 times, most recently
from
4903b51
to
a743e05
Compare
nekohasekai
force-pushed
the
dev
branch
6 times, most recently
from
98a9f6a
to
37bee34
Compare
nekohasekai
force-pushed
the
dev
branch
3 times, most recently
from
d9a5120
to
9e478d9
Compare
nekohasekai
force-pushed
the
dev
branch
12 times, most recently
from
50fa1ab
to
cd17884
Compare
nekohasekai
force-pushed
the
dev
branch
7 times, most recently
from
8452992
to
c80c8f9
Compare
nekohasekai
force-pushed
the
dev
branch
11 times, most recently
from
cc74a33
to
e52e04f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LRU cache can both support a default age and specific expire time for each entry, so when we are checking for whether an entry has expired we must check if the value has an expire time and if it has expired, not if we have a default age and it has expired.