Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add high-level boundary management interface #2177

Open
wants to merge 6 commits into
base: dev-next
Choose a base branch
from

Conversation

beryll1um
Copy link

@beryll1um beryll1um commented Oct 14, 2024

I rewrote the router's boundary management part to implement dynamic management from a high-level box interface. This also includes a number of changes I made in the process of rewriting some messy parts, such as the Outbound tree bottom-top starter.

What I reallly need is someone how is experianced in this project (like @nekohasekai) to check my changes and verify everything good and I didn't forget anything. I'm planning to run my project on it, so wait for more improvements in the future =)

@beryll1um beryll1um force-pushed the dev-router-boundary-management branch 2 times, most recently from 0d7c3e6 to b611205 Compare October 15, 2024 00:03
@beryll1um
Copy link
Author

Still working on some minor improvements and bug fixes. I think this change requires better logging for closing outbound, but not all outbound implementations have a close method, which makes it a bit messy, so maybe we'll have to do the same thing we do on inbound to unify the outbound close interface and put the close log there.

@beryll1um
Copy link
Author

beryll1um commented Oct 15, 2024

See examples in #2180!

@beryll1um
Copy link
Author

Revised few boundary mutex read lock places, and improved the structure of the Router interface and implementation.

nekohasekai and others added 3 commits October 19, 2024 21:26
I rewrote the router's boundary management part to implement dynamic management
from a high-level box interface. This also includes a number of changes I made
in the process of rewriting some messy parts, such as the Outbound tree
bottom-top starter.
@beryll1um beryll1um force-pushed the dev-router-boundary-management branch from f25cb7c to 99840ba Compare October 20, 2024 13:21
@nekohasekai nekohasekai force-pushed the dev-next branch 7 times, most recently from ac6c4b0 to 6740910 Compare October 23, 2024 08:57
@nekohasekai nekohasekai force-pushed the dev-next branch 5 times, most recently from 81dc9e7 to d6597fa Compare November 4, 2024 15:21
@nekohasekai nekohasekai force-pushed the dev-next branch 2 times, most recently from 58913be to b148629 Compare November 6, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants