Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #5

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Update README #5

merged 4 commits into from
Feb 11, 2025

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Feb 11, 2025

Hi again! I had some issues getting the deployed app to connect to Snowflake. After sleuthing the container logs, I realized that:

  1. The Docker container needs to be run in interactive mode
  2. The Docker container cannot be detached (at least, I don't think so?)

Because the config is using externalbrowser to authenticate, we need to be able to run the container interactively. I also wasn't able to figure out how to get the Docker container to open a new browser for authentication, so I did a workaround by opening the URL and providing the token manually instead in the shell session. This consequently required me to not run the container in detached mode.

I have documented what I did in this README - happy to discuss more if needed!

Changelog

  • Mention another way to set the default warehouse by going to one's profile
  • Add additional details to the "Launch your Application on AWS EC2" section on how to manually authenticate the user
  • Reformat the section to match previous sections

@vpchung vpchung requested a review from a team as a code owner February 11, 2025 04:01
Copy link
Collaborator

@jaymedina jaymedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great! Unfortunately it does look like we need to run the container in interactive mode for SSO to work, so I'll move forward with merging this and make a separate ticket for exploring a workaround later.

Thanks for updating the docs :)

@jaymedina jaymedina merged commit 9d713b0 into Sage-Bionetworks:main Feb 11, 2025
1 check passed
@thomasyu888
Copy link
Member

thomasyu888 commented Feb 11, 2025

These changes look great! Unfortunately it does look like we need to run the container in interactive mode for SSO to work, so I'll move forward with merging this and make a separate ticket for exploring a workaround later.

Thanks for updating the docs :)

Thanks @vpchung and @jaymedina . The RBAC role refactor is going to bear fruit here, as I personally think the ideal solution is to create service accounts without ability to login with user/password combo with read-only permissions to the silver/gold layer tables that is geared specifically towards hosting of these applications.

For now this is a great work-around!

@jaymedina
Copy link
Collaborator

create service accounts without ability to login with user/password combo with read-only permissions to the silver/gold layer tables

Ah! The service account is a great point. Will note this in the ticket.

@vpchung
Copy link
Member Author

vpchung commented Feb 11, 2025

+1 on the service account approach.

@vpchung vpchung deleted the update-readme branch February 11, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants