IT-3448: procedure to simplify listing file downloaders #27
Conversation
|
| @@ -0,0 +1,41 @@ | |||
| CREATE OR REPLACE PROCEDURE list_downloaders(start_record_date string, entity_list string) | |||
There was a problem hiding this comment.
Could we use the DATE type here? string is also fine, but you can do something like
record_date > DATE('2024-02-16')
| query_str2 varchar default | ||
| 'download (user_id, timestamp, entity_id) as ( | ||
| select fd.user_id, fd.timestamp, fd.association_object_id as entity_id | ||
| from filedownload fd |
There was a problem hiding this comment.
So to use this function, I assume you have to do:
USE SCHEMA synapse_data_warehouse.synapse # or ...dev.synapse
Is that right?
|
| AS | ||
| declare | ||
| rs resultset; | ||
| query_str1 varchar default ( |
There was a problem hiding this comment.
Could these query_str1 2, 3, 4 be renamed to something that describes what the query is collecting?
Like query_for_all_nodes
| 'download (user_id, timestamp, entity_id) as ( | ||
| select fd.user_id, fd.timestamp, fd.association_object_id as entity_id | ||
| from filedownload fd | ||
| join filetree ft on ft.id = fd.association_object_id |
There was a problem hiding this comment.
node_latest only contains the entities that have a Synapse ID, however, files stored within a table that have a column type of File don't have Synapse IDs. These only have the ID of the file handle, and that file handle ID is attached to the table through a filehandleassociation table (See this related Jira ticket)
Suppose I wanted to get download statistics for one or more of these kinds of files, should this be supported in this stored procedure?
Phrased another way:
Given a table in Synapse that contains a column of type File, suppose I want to retrieve the stats on the downloads for one or more rows in that table. Is there (Or should there be) a stored procedure for this functionality?
|
I see a couple of stored procedures which already exist in SYNAPSE_DATA_WAREHOUSE.SYNAPSE that look similar to what we're trying to merge here. Were those procedures created "off the books" (there's no record of their creation in schemachange) and this PR is meant to put one of those procedures back on the books? 
|
I think that is what happened. @xschildw created these with his SYSADMIN account directly in the warehouse and then backfilled this PR. This is the first stored procedure to be added through schemachange. @philerooski i wonder if we can create a Jira ticket to finalize this. |
philerooski
force-pushed
the
dev
branch
2 times, most recently
from
a6d2502 to
948e550
Compare
This PR creates a procedure to simplify list who dowloaded files within one or more subtrees.
Example: 'call list_downloaders('2021-01-01', '25982471')
Returns a table: