-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate OC Python projects to uv (SMR-8) #2984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b185541
to
442db2e
Compare
7004153
to
5bc42fb
Compare
vpchung
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
$ nx prepare openchallenges-data-lambda
> nx run openchallenges-data-lambda:prepare
> uv sync
...
... [truncated]
————————————————————————
NX Successfully ran target prepare for project openchallenges-data-lambda (11s)
No external changes found 👍🏼 :
$ nx run openchallenges-data-lambda:invoke --event events/event.json
> nx run openchallenges-data-lambda:invoke --event events/event.json
> curl -X POST 'http://localhost:9000/2015-03-31/functions/function/invocations' --data @events/event.json
{"statusCode": 200, "body": "{\"message\": \"Data successfully pulled from OC Data google sheet.\"}"}
————————————————————————
NX Successfully ran target invoke for project openchallenges-data-lambda (5s)
With additional flags:
--event=events/event.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to https://sagebionetworks.jira.com/browse/SMR-8
Description
This PR migrates two OC Python project to the package manager
uv
.The projects are:
openchallenges-data-lambda
openchallenges-etl-data
Changelog
uv
as its preferred package manager.openchallenges-data-lambda
to3.13.1
.openchallenges-edam-etl
to3.12.8
.openchallenges-data-lambda:serve
.openchallenges-data-lambda
to useuv
.openchallenges-edam-etl
to useuv
and multi-stage build..pdm-build
to workspace-level.gitignore
.workspace-nuke
.Notes
The Dockerfile of the lambda project was adapted from this example provided by
uv
.Preview
Install with uv (18 seconds, 12x faster than current setup)
Installation with Pyenv and Poetry (3m40s)
How to test
.venv
and other untracked folders fromapps/openchallenges/data-lambda
.nx prepare openchallenges-data-lambda
from the workspace directory.apps/openchallenges/data-lambda/README.md
to verify that the lambda function works properly.