SWC-7131 - workaround - do not render components that are not visible #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug occurs when we hide the visibility of a ReactComponentV2 widget containing a GWT widget inside of another ReactComponentV2 widget, but only when using the React production build. In both the React production and the development build, the ReactElement does have the expected
styleprop withdisplay: "none", but the DOM node does not get the inline style in production mode.I could not find a related bug in the React issue tracker.
As a workaround, we can simply omit rendering elements that are not visible. One risk of this approach is that any element state will be reset when the visibility is toggled.