Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWC-7063 #5577

Merged
merged 6 commits into from
Nov 7, 2024
Merged

SWC-7063 #5577

merged 6 commits into from
Nov 7, 2024

Conversation

jay-hodgson
Copy link
Member

No description provided.

…at have since been reimplemented in react). Change fields to use a display flex row (and column for each item) layout. Change DOI to be a View DOI link (to match design)
@jay-hodgson
Copy link
Member Author

Screenshot 2024-11-07 at 10 38 25 AM Screenshot 2024-11-07 at 10 57 24 AM

@jay-hodgson
Copy link
Member Author

Design:
Screenshot 2024-11-07 at 11 00 58 AM

@jay-hodgson
Copy link
Member Author

(Note, the help icon size and position has been fixed since the screenshot was taken)

@jay-hodgson jay-hodgson requested a review from nickgros November 7, 2024 19:27
Comment on lines -141 to -148
view.setRestrictionPanelVisible(
en instanceof TableEntity ||
en instanceof Folder ||
en instanceof DockerRepository
);
}
if (bundle.getEntity() instanceof Folder) {
containerItemCountWidget.configure(bundle.getEntity().getId());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this unused code!

Copy link
Contributor

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jay-hodgson jay-hodgson marked this pull request as ready for review November 7, 2024 23:20
@jay-hodgson jay-hodgson merged commit 62bfc97 into Sage-Bionetworks:develop Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants