SWC-7126 - Fix bootstrapping redirect bug #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… placeController before it has been set
nickgros
commented
Oct 23, 2024
|
|
||
| FluentFuture | ||
| .from( | ||
| whenAllComplete( | ||
| featureFlagConfigFuture, | ||
| synapsePropertiesFuture, | ||
| checkForUserChangeFuture |
There was a problem hiding this comment.
We have a dependency cycle where AuthenticationControllerImpl.checkForUserChangeFuture may try to call GlobalApplicationStateImpl.goTo, but GlobalApplicationStateImpl.goTo relies on the PlaceController, which is not ready; it is initialized and set in this future's callback (on line 167 (old) / 164 (new).
We'll run the first two futures, but defer running checkForUserChangeFuture until the placeController is set
nickgros
commented
Oct 23, 2024
Comment on lines
+173
to
+178
| whenAllComplete( | ||
| // Checking the session may result in a redirect, so this must be invoked after `setPlaceController` | ||
| ginjector | ||
| .getAuthenticationController() | ||
| .getCheckForUserChangeFuture() | ||
| ) |
There was a problem hiding this comment.
using this whenAllComplete.call pattern just the like the outer future so we can call the wrapping onFailure method if this fails.
nickgros
commented
Oct 23, 2024
| ) | ||
| .call( | ||
| () -> { | ||
| globalApplicationState.init( |
There was a problem hiding this comment.
Finally, call globalApplicationState.init
nickgros
changed the title
jay-hodgson
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWC-7126
Fix bug where authenticationController might try to use placeController before it has been set