-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWC-6533 #5539
SWC-6533 #5539
Conversation
… login instead of showing it here
); | ||
hostName2OneSageSite.put( | ||
"portal-dev.dev.sagebase.org", | ||
"https://accounts-dev.dev.sagebase.org/?appId=dev.synapse.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not yet exist, see IT-3848 and PORTALS-3203
hostName2OneSageSite.put( | ||
"localhost", | ||
"http://localhost:3000/?appId=localhost" | ||
); | ||
hostName2OneSageSite.put( | ||
"127.0.0.1", | ||
"http://127.0.0.1:3000/?appId=localhost" | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to handle both
@Override | ||
public void gotoLoginPage() { | ||
//tell One Sage to return to the current url | ||
cookieProvider.setCookie(ONESAGE_REDIRECT_COOKIE_KEY, gwt.getCurrentURL()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto feedback from Sage-Bionetworks/synapse-web-monorepo#1252 , consider expiring
view.setSynAlert(synAlert); | ||
view.setPresenter(this); | ||
} | ||
|
||
@Override | ||
public void onAcceptTermsOfUse() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I sign in to OneSage and have not accepted the terms of use, that app already handles prompting today (before new ToS implementation)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should. The ApplicationSessionManager attempts to initialize the session (used in OneSage AppWrapper). In doing so, it tries to get your User Profile, and looks for the "Terms of use have not been signed" error. It sets the ApplicationSessionContext acceptsTermsOfUse value. If this value is false, then in AppInitializer, it will redirect you to /authenticated/signTermsOfUse, showing you the TermsOfUsePage
In stack 518, send to One Sage for login! |
update LoginPresenter to often go to the One Sage root page to handle login instead of showing it here