Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWC-6533 #5539

Merged
merged 8 commits into from
Oct 16, 2024
Merged

SWC-6533 #5539

merged 8 commits into from
Oct 16, 2024

Conversation

jay-hodgson
Copy link
Member

update LoginPresenter to often go to the One Sage root page to handle login instead of showing it here

);
hostName2OneSageSite.put(
"portal-dev.dev.sagebase.org",
"https://accounts-dev.dev.sagebase.org/?appId=dev.synapse.org"
Copy link
Member Author

@jay-hodgson jay-hodgson Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not yet exist, see IT-3848 and PORTALS-3203

Comment on lines +257 to +264
hostName2OneSageSite.put(
"localhost",
"http://localhost:3000/?appId=localhost"
);
hostName2OneSageSite.put(
"127.0.0.1",
"http://127.0.0.1:3000/?appId=localhost"
);
Copy link
Contributor

@nickgros nickgros Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to handle both

@Override
public void gotoLoginPage() {
//tell One Sage to return to the current url
cookieProvider.setCookie(ONESAGE_REDIRECT_COOKIE_KEY, gwt.getCurrentURL());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto feedback from Sage-Bionetworks/synapse-web-monorepo#1252 , consider expiring

view.setSynAlert(synAlert);
view.setPresenter(this);
}

@Override
public void onAcceptTermsOfUse() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I sign in to OneSage and have not accepted the terms of use, that app already handles prompting today (before new ToS implementation)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should. The ApplicationSessionManager attempts to initialize the session (used in OneSage AppWrapper). In doing so, it tries to get your User Profile, and looks for the "Terms of use have not been signed" error. It sets the ApplicationSessionContext acceptsTermsOfUse value. If this value is false, then in AppInitializer, it will redirect you to /authenticated/signTermsOfUse, showing you the TermsOfUsePage

@jay-hodgson jay-hodgson marked this pull request as ready for review October 16, 2024 21:59
@jay-hodgson
Copy link
Member Author

In stack 518, send to One Sage for login!

@jay-hodgson jay-hodgson merged commit b2ed00d into Sage-Bionetworks:develop Oct 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants