SWC-6653 #5255
Merged
SWC-6653 #5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-hodgson
requested review from
hallieswan and
nickgros
and removed request for
hallieswan
jay-hodgson
commented
Jan 11, 2024
| @@ -107,6 +109,10 @@ public void invoke() { | |||
| refreshApprovalState(); | |||
| } | |||
| }; | |||
There was a problem hiding this comment.
Expose the AR ID for the legacy ACT AR widget, and the Lock AR (if ACT)
There was a problem hiding this comment.
And only show the "Covered Entities" if ACT
jay-hodgson
commented
Jan 11, 2024
| container.setVisible(false); | ||
| } | ||
|
|
||
| public void configure(String accessRequirementId) { | ||
| AccessRequirementRelatedProjectsListProps props = | ||
| AccessRequirementRelatedProjectsListProps.create(accessRequirementId); | ||
| ReactNode component = React.createElementWithThemeContext( | ||
| ReactNode component = React.createElementWithSynapseContext( |
There was a problem hiding this comment.
Bug 2: Pass the full Synapse Context, including the access token. Without this, only Public projects were able to be resolved in the related projects component.
There was a problem hiding this comment.
Thanks for catching this!
jay-hodgson
commented
Jan 11, 2024
| @@ -55,7 +65,7 @@ public void setTeamSubjectsWidget(IsWidget w) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void setEntitySubjectsWidget(IsWidget entitySubjectsWidget) { | |||
| public void setEntitySubjectsWidget(IsWidget w) { | |||
There was a problem hiding this comment.
Bug 1: Typo. entitySubjectsWidget should be w (local vs member variable)
|
As ACT: Additionally, with fix for bug 2 (context passed to related projects): As non-ACT: |
nickgros
approved these changes
Jan 11, 2024
hallieswan
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.