Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/sebmac 359 seb crashes on fullscreen #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GerhardAM
Copy link
Contributor

No description provided.

Small code improvements.
@GerhardAM GerhardAM requested a review from danschlet March 14, 2022 15:08
@danschlet
Copy link
Member

Unfortunately it is necessary to explicitly close the open browser windows, because when reconfiguring the ones from the previous session stay open. After a lot of trial-and-error, I found out that the full screen window cannot be closed when the property releasedWhenClosed is used, so I changed that for such a full screen main browser window. I still think it's better to release all other windows when they get closed, therefore this special treatment of the one window type which causes the crash.

@danschlet danschlet closed this Mar 17, 2022
@danschlet danschlet reopened this Mar 17, 2022
@danschlet danschlet force-pushed the bug/SEBMAC-359_SEB_crashes_on_fullscreen branch from f2bff7a to aecde91 Compare May 16, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants