Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved operations on cells #985

Merged
merged 57 commits into from
Jan 19, 2025
Merged

feat: improved operations on cells #985

merged 57 commits into from
Jan 19, 2025

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jan 19, 2025

Closes partially #977

Summary of Changes

  • Operations are now wrapped into the classes
    • DatetimeOperations (formerly TemporalCell)
    • DurationOperations
    • MathOperations
    • StringOperations (formerly StringCell)
  • Stabilize operations on datetime/date/time
  • Stabilize operations on durations

They do are not really containers, just a namespace for computations.
… `TemporalOperations`

They are not subclasses of `Cell`, which might be implied by the name.
@lars-reimann lars-reimann requested a review from a team as a code owner January 19, 2025 15:47
@lars-reimann lars-reimann changed the title feat: improved temporal operations feat: improved operations on cells Jan 19, 2025
Copy link
Contributor

github-actions bot commented Jan 19, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 110 0 0 1.79s
✅ PYTHON mypy 110 0 3.64s
✅ PYTHON ruff 110 0 0 0.3s
✅ REPOSITORY git_diff yes no 0.28s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 97.93814% with 12 lines in your changes missing coverage. Please review.

Project coverage is 95.16%. Comparing base (96be911) to head (9af7503).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...feds/data/tabular/query/_lazy_string_operations.py 87.32% 9 Missing ⚠️
...ation/_convert_and_check_datetime_format_module.py 94.82% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #985    +/-   ##
========================================
  Coverage   95.16%   95.16%            
========================================
  Files         127      135     +8     
  Lines        7790     8047   +257     
========================================
+ Hits         7413     7658   +245     
- Misses        377      389    +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit 7396c94 into main Jan 19, 2025
10 checks passed
@lars-reimann lars-reimann deleted the string-cell branch January 19, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants