Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stabilize Row class #980

Merged
merged 2 commits into from
Jan 13, 2025
Merged

feat: stabilize Row class #980

merged 2 commits into from
Jan 13, 2025

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jan 13, 2025

Closes partially #977

Summary of Changes

  • Narrow types of parameters and results for better type checking.
  • Improve tests and documentation.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 98 0 0 1.3s
✅ PYTHON mypy 98 0 3.54s
✅ PYTHON ruff 98 0 0 0.09s
✅ REPOSITORY git_diff yes no 0.08s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (db85617) to head (faa7904).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #980   +/-   ##
=======================================
  Coverage   94.99%   95.00%           
=======================================
  Files         123      123           
  Lines        7696     7711   +15     
=======================================
+ Hits         7311     7326   +15     
  Misses        385      385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit ca1ce3d into main Jan 13, 2025
10 checks passed
@lars-reimann lars-reimann deleted the finalize-row branch January 13, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant