Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make data parameter of Table and Column required #978

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

lars-reimann
Copy link
Member

Summary of Changes

The data parameter of Table and Column must now be specified. Being able to omit it was nice for tests, but also means that users might forget to specify their data. Since tables and columns are immutable, creating an empty table is rarely useful in practice.

@lars-reimann lars-reimann changed the title feat: make data parameter of Table and Column required feat: make data parameter of Table and Column required Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 78 0 0 2.12s
✅ PYTHON mypy 78 0 3.93s
✅ PYTHON ruff 78 0 0 0.3s
✅ REPOSITORY git_diff yes no 0.29s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.42%. Comparing base (7a7fa77) to head (324bb16).

Files with missing lines Patch % Lines
src/safeds/data/tabular/containers/_table.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   94.42%   94.42%   -0.01%     
==========================================
  Files         121      121              
  Lines        7463     7459       -4     
==========================================
- Hits         7047     7043       -4     
  Misses        416      416              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit 29fdefa into main Jan 8, 2025
8 checks passed
@lars-reimann lars-reimann deleted the require-data branch January 8, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants