-
Notifications
You must be signed in to change notification settings - Fork 0
feat: include the purity analysis into the 'run_api` command #241
feat: include the purity analysis into the 'run_api` command #241
Conversation
…a class for class methods | fixed testdata
…39-feat-include-the-purity-analysis-into-the-run_api-command # Conflicts: # src/library_analyzer/processing/api/purity_analysis/_get_module_data.py
…39-feat-include-the-purity-analysis-into-the-run_api-command # Conflicts: # src/library_analyzer/processing/api/purity_analysis/_get_module_data.py
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
…ysis-into-the-run_api-command' into 239-feat-include-the-purity-analysis-into-the-run_api-command # Conflicts: # src/library_analyzer/processing/api/purity_analysis/_resolve_references.py
…e-run_api-command # Conflicts: # src/library_analyzer/processing/api/purity_analysis/_get_module_data.py # src/library_analyzer/processing/api/purity_analysis/_resolve_references.py
…e-run_api-command
… module analysis)" This reverts commit a4db98d.
… fixed missing origin bug
…sis-into-the-run_api-command
This PR is ready for review, except for the one failed test due to a recursion bug I cannot fix. It would be great if you could take a look at it @lars-reimann. I tried to change the |
…ysis-into-the-run_api-command' into 239-feat-include-the-purity-analysis-into-the-run_api-command # Conflicts: # src/library_analyzer/processing/api/purity_analysis/_get_module_data.py
@lars-reimann the fix we found lead to some other tests failing. I will fix this, but it will take a while.
|
No worries and good luck with that. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 92.67% 92.89% +0.22%
==========================================
Files 97 98 +1
Lines 6467 6773 +306
==========================================
+ Hits 5993 6292 +299
- Misses 474 481 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only had time for spot checks, but in that context everything looks great. Thank you!
Closes #239
Summary of Changes
The newly added purity analysis entry function:
get_purity_result
is now called when therun_api
command is executed.It is the starting point of the purity analysis and runs it on the provided
src_path
string, representing the package to analyze.This includes further improvements and bug fixes to the purity analysis itself.