Skip to content
This repository was archived by the owner on Nov 23, 2024. It is now read-only.

feat: purity analysis for chained functions and simple cyclic functions #203

Merged
merged 288 commits into from
Jan 3, 2024
Merged

feat: purity analysis for chained functions and simple cyclic functions #203

merged 288 commits into from
Jan 3, 2024
+2,876 −1,061

Conversation

lukarade
Copy link
Contributor

@lukarade lukarade commented Dec 18, 2023 •
edited
Loading

Closes #77

Summary of Changes

This feature adds the last part of the purity analysis:

  • We now build a topologically sorted graph and filter out simple cyclic function calls.
  • then we infer the purity/(impurity) for all functions in that call graph
  • if a function is impure, we also collect all reasons for its impurity
  • we use caching to store already computed functions and look them up when needed

There are still a few things that need improvement:

  • Nested cyclic functions
  • member access
  • further analysis of unknown reasons for impurity

lukarade and others added 30 commits May 24, 2023 23:42
@lukarade
fix: fixed some more linter problems
fb8ad25
@lukarade
fix: fixed some more linter problems
cbe1623
@lukarade
fix: linter fixes
b70dcc9
@lukarade
fixup! fix: linter fixes
219d63c
@lukarade
fix: more linter fixes
ea93ba6
@lukarade
fix: linter fixes
c28b61d
@lukarade
fix: linter fixes
16b2746
@lukarade
Merge branch 'main' into 90-function-to-resolve-references
d24e4c6
@megalinter-bot
style: apply automated linter fixes
1498d0d
@megalinter-bot
style: apply automated linter fixes
9c0c096
@lukarade
fix: removed all code that is not relevant for this PR
af697b2
@megalinter-bot
style: apply automated linter fixes
7a80dd8
@lukarade
fix: removed detection of Call and adapted test cases to no longer co…
f603cf3 
…ntain `parent`
@megalinter-bot
style: apply automated linter fixes
eb1d48d
@lukarade
feat: parent-node now uses NodeScope Type
75d8b08
@lukarade
Merge remote-tracking branch 'origin/90-function-to-resolve-reference…
6cec4b1 
…s' into 90-function-to-resolve-references
@lukarade
fix: linter fixes
3f52312
@lukarade
Merge branch 'main' into 90-function-to-resolve-references
4fe9c5c
@lukarade
fix: more linter fixes
9dfbb40
@lukarade
fix: final linter fixes
5ee2c89
@lukarade
Merge branch 'main' into 90-function-to-resolve-references
81d2080
@lukarade
fix: reverted unintended changes to package-lock.json
fc56ca1
@lukarade
refactor: renamed NodeScope to ScopeNode and added function for d…
4615138 
…uplicated code
@lukarade
docs: added documentation for resolve_references.py
c2db888
@megalinter-bot
style: apply automated linter fixes
09c0f7b
@lukarade
fix: implemented code revision improvements
ebaf5fb
@lukarade
test: added testcases for detection of class and instance variables
bac789a
@lukarade
feat: implemented detection of class and instance variables
56db620
@lukarade
fix: fixed SimpleVariables attributes to always be of type list
00f5ac9
@lukarade
cherry-picking from newer version
48f8224
lukarade and others added 19 commits December 19, 2023 19:00
@lukarade
test: removed all failing testcases - they will need new features
7382f42
@lukarade
fix: refactored resolve_references to return a dict
6710651
@lukarade
Merge remote-tracking branch 'origin/purity-analysis' into purity-ana…
e788ae5 
…lysis
@lukarade
fix: mypy linter fixes
8e7f814
@lukarade
fix: fixed a bug (references with the same name were lost due to the …
0966d0d 
…dict) in resolve_reference, adapted infer_purity to use this correctly
@lukarade
fix: linter fixes
1bcddbb
@lukarade
fix: more linter fixes
2d35422
@lukarade
fix: more linter fixes
4411cde
@lukarade
fix: more linter fixes
e4a1637
@lukarade
fix: fixed infer_purity type errors
5e9908b
@lukarade
fix: fixed infer_purity type errors
0d2bf76
@lukarade
fix: fixed infer_purity type errors
0b4c2e4
@lukarade
fix: fixed infer_purity type errors
d3bfa76
@lukarade
fix: fixed infer_purity type errors
13bb0a6
@lukarade
fix: final linter fixes
be4048d
@lukarade
fix: docs
b4bead8
@megalinter-bot
style: apply automated linter fixes
5dace54
@lukarade
fix: automated fixes fixed
7bab4c7
@megalinter-bot
style: apply automated linter fixes
fa21d97
@lukarade lukarade marked this pull request as ready for review December 22, 2023 01:06
@lukarade lukarade requested a review from a team as a code owner December 22, 2023 01:06
@lukarade lukarade mentioned this pull request Jan 1, 2024
Merged
@lukarade
Merge branch 'main' into purity-analysis
Loading
Loading status checks…
017f157
@lukarade
Copy link
Contributor Author

lukarade commented Jan 2, 2024

If this is merged, also merge #204 - it fixes all docstrings.

@lukarade lukarade self-assigned this Jan 2, 2024
@lukarade lukarade added the purity Inferring the purity of functions label Jan 2, 2024
@lars-reimann lars-reimann merged commit e1b4c57 into main Jan 3, 2024
@lars-reimann lars-reimann deleted the purity-analysis branch January 3, 2024 20:00
lars-reimann pushed a commit that referenced this pull request Jan 12, 2024
@lukarade @megalinter-bot
fix: Purity analysis Docstrings (#204)
4018728 
### Summary of Changes

- Fixed existing Docstrings to follow the numbydoc style guide
- Added all missing Docstrings for all classes and functions

**Only merge after #203**

---------

Co-authored-by: megalinter-bot <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lars-reimann lars-reimann

Assignees

@lukarade lukarade

Labels
purity Inferring the purity of functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Second Iteration for Purity-analysis
3 participants
@lukarade @lars-reimann @megalinter-bot