fix: Wait for tree-kill during deactivation if child process does not respond #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #807 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 86
Lines 13633 13633
Branches 2881 2881
=========================================
Hits 13633 13633 ☔ View full report in Codecov by Sentry. |
lars-reimann
reviewed
Dec 5, 2023
Co-authored-by: Lars Reimann <[email protected]>
lars-reimann
approved these changes
Dec 5, 2023
lars-reimann
pushed a commit
that referenced
this pull request
Jan 15, 2024
## [0.6.0](v0.5.1...v0.6.0) (2024-01-15) ### Features * CLI command to run formatting ([#824](#824)) ([a74b8e0](a74b8e0)), closes [#702](#702) * CLI command to run validation ([#820](#820)) ([7c2526d](7c2526d)), closes [#703](#703) * Partial execution of pipelines ([#821](#821)) ([1e0d03b](1e0d03b)) * python server (runtime) ([#726](#726)) ([78d16f1](78d16f1)), closes [#806](#806) ### Bug Fixes * **deps-dev:** Bump vite from 4.4.9 to 5.0.5 ([#808](#808)) ([c9575e7](c9575e7)), closes [#15203](https://github.com/Safe-DS/DSL/issues/15203) [#15203](https://github.com/Safe-DS/DSL/issues/15203) [#15140](https://github.com/Safe-DS/DSL/issues/15140) [#15140](https://github.com/Safe-DS/DSL/issues/15140) [#15225](https://github.com/Safe-DS/DSL/issues/15225) [#15225](https://github.com/Safe-DS/DSL/issues/15225) [#15223](https://github.com/Safe-DS/DSL/issues/15223) [#15223](https://github.com/Safe-DS/DSL/issues/15223) [#15233](https://github.com/Safe-DS/DSL/issues/15233) [#15233](https://github.com/Safe-DS/DSL/issues/15233) [#15229](https://github.com/Safe-DS/DSL/issues/15229) [#15229](https://github.com/Safe-DS/DSL/issues/15229) [#15189](https://github.com/Safe-DS/DSL/issues/15189) [#15189](https://github.com/Safe-DS/DSL/issues/15189) [#15218](https://github.com/Safe-DS/DSL/issues/15218) [#15218](https://github.com/Safe-DS/DSL/issues/15218) [#15220](https://github.com/Safe-DS/DSL/issues/15220) [#15220](https://github.com/Safe-DS/DSL/issues/15220) [#15181](https://github.com/Safe-DS/DSL/issues/15181) [#15181](https://github.com/Safe-DS/DSL/issues/15181) [#15194](https://github.com/Safe-DS/DSL/issues/15194) [#15194](https://github.com/Safe-DS/DSL/issues/15194) [#15179](https://github.com/Safe-DS/DSL/issues/15179) [#15179](https://github.com/Safe-DS/DSL/issues/15179) [#15228](https://github.com/Safe-DS/DSL/issues/15228) [#15228](https://github.com/Safe-DS/DSL/issues/15228) [#15204](https://github.com/Safe-DS/DSL/issues/15204) [#15204](https://github.com/Safe-DS/DSL/issues/15204) [#15207](https://github.com/Safe-DS/DSL/issues/15207) [#15207](https://github.com/Safe-DS/DSL/issues/15207) [#15162](https://github.com/Safe-DS/DSL/issues/15162) [#15162](https://github.com/Safe-DS/DSL/issues/15162) [#15135](https://github.com/Safe-DS/DSL/issues/15135) [#15178](https://github.com/Safe-DS/DSL/issues/15178) [#15135](https://github.com/Safe-DS/DSL/issues/15135) [#15178](https://github.com/Safe-DS/DSL/issues/15178) [#15173](https://github.com/Safe-DS/DSL/issues/15173) [#15173](https://github.com/Safe-DS/DSL/issues/15173) [#15137](https://github.com/Safe-DS/DSL/issues/15137) [#15137](https://github.com/Safe-DS/DSL/issues/15137) [#15166](https://github.com/Safe-DS/DSL/issues/15166) [#15166](https://github.com/Safe-DS/DSL/issues/15166) [#15171](https://github.com/Safe-DS/DSL/issues/15171) [#15171](https://github.com/Safe-DS/DSL/issues/15171) [#15093](https://github.com/Safe-DS/DSL/issues/15093) [#15093](https://github.com/Safe-DS/DSL/issues/15093) [#15135](https://github.com/Safe-DS/DSL/issues/15135) [#15135](https://github.com/Safe-DS/DSL/issues/15135) [#15154](https://github.com/Safe-DS/DSL/issues/15154) [#15154](https://github.com/Safe-DS/DSL/issues/15154) [#15155](https://github.com/Safe-DS/DSL/issues/15155) [#15155](https://github.com/Safe-DS/DSL/issues/15155) [#14569](https://github.com/Safe-DS/DSL/issues/14569) [#14569](https://github.com/Safe-DS/DSL/issues/14569) [#15145](https://github.com/Safe-DS/DSL/issues/15145) [#15145](https://github.com/Safe-DS/DSL/issues/15145) [#15049](https://github.com/Safe-DS/DSL/issues/15049) [#15049](https://github.com/Safe-DS/DSL/issues/15049) [#15059](https://github.com/Safe-DS/DSL/issues/15059) [#15059](https://github.com/Safe-DS/DSL/issues/15059) [#15233](https://github.com/Safe-DS/DSL/issues/15233) [#15189](https://github.com/Safe-DS/DSL/issues/15189) [#15229](https://github.com/Safe-DS/DSL/issues/15229) [#15220](https://github.com/Safe-DS/DSL/issues/15220) [#15225](https://github.com/Safe-DS/DSL/issues/15225) [#15228](https://github.com/Safe-DS/DSL/issues/15228) [#15223](https://github.com/Safe-DS/DSL/issues/15223) [#15207](https://github.com/Safe-DS/DSL/issues/15207) [#15218](https://github.com/Safe-DS/DSL/issues/15218) * renaming of declarations that are imported under an alias ([#825](#825)) ([9f7363d](9f7363d)), closes [#635](#635) * use correct paths and module names to correctly execute Safe-DS files with spaces ([#811](#811)) ([191ef33](191ef33)), closes [#810](#810) * Wait for tree-kill during deactivation if child process does not respond ([#807](#807)) ([baf4a3c](baf4a3c))
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the child process does not respond, tree kill does not wait for the process to end.
This may cause VS Code to continue with shutting down, killing the first process of the tree only.
The reference to the tree is then lost, and tree-kill can no longer continue killing the other processes.
To fix this, await the completion of tree-kill.
Added some more logging