Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move callToParameterValue into NodeMapper #770

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Nov 13, 2023

Summary of Changes

Move the method callToParameterValue to SafeDsNodeMapper. Previously, it was private in SafeDsAnnotations. Given a call and a parameter (or its name), it returns the value assigned to the parameter in the call. It also takes default values into account.

Copy link

github-actions bot commented Nov 13, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.07s
✅ TYPESCRIPT eslint 3 0 0 3.91s
✅ TYPESCRIPT prettier 3 0 0 0.8s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #770 (25ee7a5) into main (061d3b1) will increase coverage by 100.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           main      #770        +/-   ##
===========================================
+ Coverage      0   100.00%   +100.00%     
===========================================
  Files         0        82        +82     
  Lines         0     11808     +11808     
  Branches      0      2453      +2453     
===========================================
+ Hits          0     11808     +11808     
Files Coverage Δ
...-lang/src/language/builtins/safe-ds-annotations.ts 100.00% <100.00%> (ø)
...s-lang/src/language/helpers/safe-ds-node-mapper.ts 100.00% <100.00%> (ø)

... and 80 files with indirect coverage changes

@lars-reimann lars-reimann marked this pull request as ready for review November 13, 2023 20:28
@lars-reimann lars-reimann merged commit 275366a into main Nov 13, 2023
6 checks passed
@lars-reimann lars-reimann deleted the call-to-parameter-value branch November 13, 2023 20:28
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant