feat: optional parameters must be passed by name #1307
Merged
+754
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1163
Summary of Changes
Optional parameters must now be passed by name. This allows reordering them in the stubs and inserting new optional parameters anywhere instead of just at the end. We can now also deprecate all optional parameters without introducing a new function.
The error has an associated quickfix (our first). This PR also adds a data-driven test system for quickfixes and other code actions.