Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional parameters must be passed by name #1307

Merged
merged 10 commits into from
Jan 8, 2025

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jan 7, 2025

Closes #1163

Summary of Changes

Optional parameters must now be passed by name. This allows reordering them in the stubs and inserting new optional parameters anywhere instead of just at the end. We can now also deprecate all optional parameters without introducing a new function.

The error has an associated quickfix (our first). This PR also adds a data-driven test system for quickfixes and other code actions.

@lars-reimann lars-reimann linked an issue Jan 7, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jan 7, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdown-link-check 3 0 0.53s
✅ REPOSITORY git_diff yes no 0.21s
✅ TYPESCRIPT eslint 12 0 0 4.75s
✅ TYPESCRIPT prettier 12 0 0 1.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (3bb111f) to head (52f2185).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1307    +/-   ##
========================================
  Coverage   99.72%   99.72%            
========================================
  Files         113      118     +5     
  Lines       12783    12905   +122     
  Branches     4199     4229    +30     
========================================
+ Hits        12748    12870   +122     
  Misses         35       35            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as draft January 7, 2025 16:50
@lars-reimann lars-reimann marked this pull request as ready for review January 8, 2025 14:40
@lars-reimann lars-reimann merged commit 674cda8 into main Jan 8, 2025
8 checks passed
@lars-reimann lars-reimann deleted the 1163-specify-optional-parameters-by-name-only branch January 8, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify optional parameters by name only
1 participant