optimized dependencies for JAR file size (8.6MB -> 7.8MB) #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driftay
reviewed
Jun 26, 2020
| @@ -99,12 +99,6 @@ | |||
| <version>1.3</version> | |||
| <scope>compile</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
We use the brigadier all throughout the command management system
There was a problem hiding this comment.
I tried compiling the plugin before pushing this request. It compiles without any problem. It seems like brigadier is already included by some other dependency.
In fact, by running mvn dependency:tree you can clearly see that
[INFO] +- me.lucko:commodore:jar:1.3:compile
[INFO] | \- com.mojang:brigadier:jar:1.0.14:compile
The me.lucko.commodore package already includes brigadier.
|
No updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some unused packages and dependencies to optimize file size.
If net.dv8tion's JDA was to be removed, the JAR file would go from 7.8MB to a relatively small 2.7MB.
The Discord API is taking up a real lot of space. I'm looking for a smaller alternative, however I have limited time and I'm not sure I'll be able to find and implement it.