Force read-mode in av.open
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threeal
approved these changes
Nov 19, 2023
MahmoudAshraf97
approved these changes
Nov 21, 2023
|
Hi there, we're experiencing the same issue. Please do you know if this kind of fixes can be released soon? Many thanks 🙏🏻 |
|
@gonzaloplaza while I have some approvals it looks like we're waiting on an "approving review"; this is my first PR here so I don't know how many folks can provide that or what to expect on timeline 🤷 |
nguyendc-systran
approved these changes
Nov 27, 2023
The `av.open` functions checks input metadata to determine the mode to open with ("r" or "w"). If an input to `decode_audio` is found to be in write-mode, without this change it can't be read. Forcing read mode solves this.
nguyendc-systran
force-pushed
the
patch-1
branch
from
922ecb7 to
d4a6a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
av.openfunctions checks input metadata to determine the mode to open with ("r" or "w"). If an input todecode_audiois found to be in write-mode, it will fail. Forcing read mode solves this.I encountered this in a FastAPI application, where I used the
UploadFiletype to accept a file in my API endpoint. This uses aSpooledTemporaryFileunderneath. In some circumstances, such as with small input files, this spooled file will have mode "w+b" when we first attempt to read it, causingdecode_audioto try opening withav.openin write mode, and failing. Forcing to read-mode fixes this.It would not make sense for
av.openindecode_audioto ever use write-mode, so this should not negatively impact any other uses.