Container to DocBook #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 4, 2023 12:38
added 3 commits
August 9, 2023 11:05
tomschr
requested changes
Aug 10, 2023
There was a problem hiding this comment.
@dmpop Thanks Dima! Don't worry about the amount of suggestions that I've made. All is fine with your docs.
It can be boiled down to these topics:
- Changes in the root element by replacing
version="5.1"toversion="5.2". - I removed all DocManager tags from each concept files. It's enough to have the tags in the assembly file.
- Don't repeat yourself with links ("be DRY"). In most cases you can use an empty
<link/>tag without the text. - Some minor things here and there. There is also an entity error.
I also discovered some inconsistencies regarding prompts. Maybe you want to address those too. 🤗
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the Container guide from ASCIIDoc to DocBook assembly.