Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review of installation, update and uninstallation procedures #86
Review of installation, update and uninstallation procedures #86
Changes from 19 commits
fbf9a18
c2a0818
ed4847e
5f27d1f
2700e01
ff524c7
2fa3f0e
19bd0c6
3a9dd52
b920afa
04e1669
a55114a
cbf367b
acc1952
0ed9655
de6edbd
04f6a03
370b2a6
21f87f4
6eee89b
5ca6d84
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've added what's not recommended. What's about the opposite? What's the recommended case? Can we add a short sentence when to use this set up?
I would extend this sentence with the following addition:
If we can reference it to another section, that would also be a solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recommended case is to have a person with K8s knowledge and have him/her deploy -manually- Trento Server components on an existing/new cluster in a production fashion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add or set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set