Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to the problem analysis section #85

Merged
merged 11 commits into from
Aug 10, 2023

Conversation

abravosuse
Copy link
Collaborator

Corrections to the problem analysis section

PR creator: Description

Corrections to the problem analysis section.

PR creator: Are there any relevant issues/feature requests?

  • bsc#...
  • jsc#SLE-...

Corrections to the problem analysis section
@abravosuse abravosuse requested a review from tomschr August 7, 2023 15:17
@abravosuse abravosuse added the prj:Trento Related to Trento documentation label Aug 8, 2023
Copy link
Contributor

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abravosuse Thank you for your contribution! 👍 Much appreciated.

I've added some comments which we can discuss in our meeting.

trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
@abravosuse abravosuse requested a review from tomschr August 9, 2023 06:47
Copy link
Contributor

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Albert!
Just some last tiny corrections that I missed last time.

trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. 👍 Thanks Alberto.

@tomschr tomschr merged commit d4dc826 into main Aug 10, 2023
12 checks passed
@tomschr tomschr deleted the abravosuse-corrections-problem-analysis branch August 10, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prj:Trento Related to Trento documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants