-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New section for user mgmt feature #165
base: main
Are you sure you want to change the base?
Conversation
@abravosuse Here is the PDF: |
Thank you very much @tomschr ! It looks great. My only suggestion would be to change the format of the Security Tip at the end of the section, to something that grabs the reader's attention better. |
Sure, no problem! 👍 I've converted it to a note and this is how it looks in HTML: |
I think the note works great, @tomschr . Thanks! Just one thing. The last two sentences should not be part of the note. Particularly: |
@abravosuse No problem. Here is the result: |
Looks good to me now, @tomschr . Thanks! Ready to merge and publish when the new version of Trento comes out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new section should be located after the section about installing the Trento agents, not before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestions @dmpop !
All good except for changes in line 764. Please review my own suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alberto! Some minor improvements with missing tags etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tomschr ! All suggestions accepted AS-IS. Two minor changes.
This PR documents the user mgmt feature that will be available with the next version of Trento, which is to be released by the end of September, beginning of October. It is to be reviewed but not merged until the new version is out.
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
e769df4
to
6a56beb
Compare
This PR documents the user mgmt feature that will be available with the next version of Trento, which is to be released by the end of September, beginning of October. It is to be reviewed but not merged until the new version is out.
PR creator: Description
Describe the overall goals of this pull request.
PR creator: Are there any relevant issues/feature requests?