Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New section for user mgmt feature #165

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Conversation

abravosuse
Copy link
Collaborator

This PR documents the user mgmt feature that will be available with the next version of Trento, which is to be released by the end of September, beginning of October. It is to be reviewed but not merged until the new version is out.

PR creator: Description

Describe the overall goals of this pull request.

PR creator: Are there any relevant issues/feature requests?

  • bsc#...
  • jsc#SLE-...

@abravosuse abravosuse added the prj:Trento Related to Trento documentation label Aug 27, 2024
@tomschr tomschr marked this pull request as draft August 30, 2024 05:28
@tomschr
Copy link
Contributor

tomschr commented Sep 5, 2024

@abravosuse Here is the PDF:

SLES-SAP-trento_en.pdf

@abravosuse
Copy link
Collaborator Author

@abravosuse Here is the PDF:

SLES-SAP-trento_en.pdf

Thank you very much @tomschr ! It looks great. My only suggestion would be to change the format of the Security Tip at the end of the section, to something that grabs the reader's attention better.

@tomschr
Copy link
Contributor

tomschr commented Sep 5, 2024

@abravosuse

My only suggestion would be to change the format of the Security Tip at the end of the section, to something that grabs the reader's attention better.

Sure, no problem! 👍 I've converted it to a note and this is how it looks in HTML:

Screenshot_20240905_144235

@abravosuse
Copy link
Collaborator Author

@abravosuse

My only suggestion would be to change the format of the Security Tip at the end of the section, to something that grabs the reader's attention better.

Sure, no problem! 👍 I've converted it to a note and this is how it looks in HTML:

Screenshot_20240905_144235

I think the note works great, @tomschr . Thanks! Just one thing. The last two sentences should not be part of the note. Particularly:
User managers can enable and disable users. When a user that is logged in in the console is disabled by a user admin, their session is terminated immediately.
This should not be in the note.

@tomschr
Copy link
Contributor

tomschr commented Sep 5, 2024

The last two sentences should not be part of the note.

@abravosuse No problem. Here is the result:

Screenshot_20240905_153308

@abravosuse
Copy link
Collaborator Author

The last two sentences should not be part of the note.

@abravosuse No problem. Here is the result:

Screenshot_20240905_153308

Looks good to me now, @tomschr . Thanks! Ready to merge and publish when the new version of Trento comes out.

Copy link
Collaborator Author

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new section should be located after the section about installing the Trento agents, not before.

trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestions @dmpop !
All good except for changes in line 764. Please review my own suggestion.

trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@dmpop dmpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alberto! Some minor improvements with missing tags etc.

trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tomschr ! All suggestions accepted AS-IS. Two minor changes.

trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
trento/xml/article_sap_trento.xml Outdated Show resolved Hide resolved
abravosuse and others added 12 commits November 15, 2024 09:26
This PR documents the user mgmt feature that will be available with the next version of Trento, which is to be released by the end of September, beginning of October. It is to be reviewed but not merged until the new version is out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prj:Trento Related to Trento documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants