Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libvirt_guest_installation.xml (PXE part)) #1774

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Conversation

aginies
Copy link
Member

@aginies aginies commented Oct 10, 2024

PR creator: Description

Fix PXE enablement (there is no Network PXE but the NIC)

PR creator: Are there any relevant issues/feature requests?

PR creator: Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

  • SLE 15/openSUSE Leap 15.x

    • SLE 15 next/openSUSE Leap next (current main, no backport necessary): 362bfe3
    • SLE 15 SP6/openSUSE Leap 15.6: d855f82
    • SLE 15 SP5/openSUSE Leap 15.5: 503493e
    • SLE 15 SP4/openSUSE Leap 15.4
    • SLE 15 SP3/openSUSE Leap 15.3
    • SLE 15 SP2/openSUSE Leap 15.2
  • SLE 12

    • SLE 12 SP5

PR reviewer only: Have all backports been applied?

The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.

  • all necessary backports are done

Fix PXE enablement (there is no Network PXE but the NIC)
fixes to provide 2 options
Adding a tip on FW features
Copy link
Collaborator

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please see some small corrections here. Thanks!

xml/libvirt_guest_installation.xml Outdated Show resolved Hide resolved
@sounix000 sounix000 merged commit 362bfe3 into main Oct 21, 2024
9 checks passed
sounix000 added a commit that referenced this pull request Oct 21, 2024
* Update libvirt_guest_installation.xml (PXE part))

Fix PXE enablement (there is no Network PXE but the NIC)

* Update libvirt_guest_installation.xml

fixes to provide 2 options

* Tip on FW features

Adding a tip on FW features

* Cosmetic modifications

* Editorial corrections

* XML formatting

---------

Co-authored-by: Souvik Sarkar <[email protected]>
sounix000 added a commit that referenced this pull request Oct 21, 2024
* Update libvirt_guest_installation.xml (PXE part))

Fix PXE enablement (there is no Network PXE but the NIC)

* Update libvirt_guest_installation.xml

fixes to provide 2 options

* Tip on FW features

Adding a tip on FW features

* Cosmetic modifications

* Editorial corrections

* XML formatting

---------

Co-authored-by: Souvik Sarkar <[email protected]>
@sounix000 sounix000 deleted the aginies-patch-1 branch October 22, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants