Enforce more strict permissions for files in Cosmos #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in post-tasks.d/010fix-ssh-perms as is done by Puppet with sunet::ssh_keys.
as well as that /root/.ssh and its content is only owned and readable by root. This is redundant if the previous permissions were properly applied and no other changes have been made by the user or something else, but is added for good measure as a layered defense.
by root since it's possible that the directory can contain files that after applying the overlay to / only should be read or writable by root.
|
Kudos, SonarCloud Quality Gate passed!
|
|
also 👍 from @mickenordin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of various stricter permissions for Cosmos that were identified to be needed when setting up the locked down Tor signing OPS repo to avoid information leakage and possible unauthorized modification by unprivileged users.
The main issue is to restrict access to $COSMOS_BASE at the earliest stage possible to avoid race conditions, during which information could be leaked or modifications made.
Permissions for sensitive files and directories such as /root and /root/.ssh in the overlay are checked separately. A fix is also included to apply the same permission for /root/.ssh/authorized_keys that Puppet applies through sunet::ssh_keys to avoid changing permissions on each run of Cosmos and Puppet.