Evaluate_pyupgrade_ruleset #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some typing imports are unnecessary with our current python version. Specifically use builtins.type for those classes that have a variable named type
Use the updated | operator for union types in python 3.10 and later PEP604
update isinstance calls to use updated | operator for union types PEP604
since python 3.3 IOError and a few others have been merged into OSError and is only an alias
|
helylle
commented
Sep 17, 2024
| except IOError: | ||
| response = "File not found".encode() | ||
| except OSError: | ||
| response = b"File not found" |
There was a problem hiding this comment.
linting said .encode() was unnecessary for ut-8 encoding but it was there to make it a bytes string literal which can be done with b-strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues from pyupgrade ruleset targetting python 3.10 as it is our current running environment.
Majority is PEP604 union operator | replacing Union[]