Evaluating ruff #683
Merged
Evaluating ruff #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helylle
commented
Sep 5, 2024
| @@ -1408,7 +1408,7 @@ def test_complete_invite_new_user(self): | |||
| email=invite.get_primary_mail_address(), | |||
| given_name=state_payload["state"]["name"]["given_name"], | |||
| surname=state_payload["state"]["name"]["surname"], | |||
| ), | |||
| ) | |||
There was a problem hiding this comment.
ruff wanted to put a parenthesis on this due to the comma and indent it all as it was a hidden tuple due to the comma
helylle
commented
Sep 5, 2024
src/eduid/maccapi/middleware.py
Outdated
There was a problem hiding this comment.
ruff wanted to remove e as an unused variable as the f-strings were just strings
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluating using ruff for reformatting and linting
Adds linting to the pipeline
Skips one rule only for now for ambiguous variable names
Some fixes included for things found when linting but mostly unused imports, formatting and explicit re-export of imports in modules