Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-586: Related Content #460

Open
wants to merge 9 commits into
base: 4.x
Choose a base branch
from
Open

Conversation

buttonwillowsix
Copy link
Contributor

@buttonwillowsix buttonwillowsix commented Jul 2, 2024

READY FOR REVIEW

Summary

-bi-directional display for related content
-prep for other uses of related content like Explore More on news
-foundation of work will also addresses several other long-standing tickets (that work will be contained in a separate PR)

Review By (Date)

-Required by end of FY24 (August 31, 2024)
-Would prefer July release if possible to enable Woods sitebuilding efforts on new sites

Criticality

Important!

Review Tasks

Setup tasks and/or behavior to test

Testing basic display of related content

  1. Check out this branch
  2. Create a bunch of people, basic page, news, events, and pub content.
  3. Create a Basic Page (let's say it is called "FIND ME BASIC!") and select a wide variety of content to be related (events, people, news, basic pages, pubs)
  4. Go to a related event, basic page, news, person, and events pages. Put a Lists paragraph on there and try the "This page related to - All" paragraph or "This page related to - Basic Pages" to see the "FIND ME BASIC" as a list item.
  5. Repeat for an Event, News, and Person
  6. Go back to "FIND ME BASIC!." Throw a Lists Paragraph on the page and select "Related Content" and then clone to try all the "Related From this Page..." variants.
  7. Verify that the expected related content shows up
  8. In all cases verify that the sort order is what you'd expect. See https://sdssuserguide-prod.stanford.edu/build/creating-content/related-content-coming-soon for documentation on expectations.

Front End Validation

This uses existing front-end patterns. Nothing new to see!

Backend / Functional Validation

Code

  • [X ] Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • [NOPE] Is there anything included in this PR that is not related to the problem it is trying to solve?
  • [ I HOPE SO] Is the approach to the problem appropriate?
  • NOTE: Some of the edit forms for content could be improved so this is in a consistent place

Affected Projects or Products

  • This will affect People and News, primarily. Handy also for many uses.

Associated Issues and/or People

  • SDSS-586
  • SDSS-297

@buttonwillowsix buttonwillowsix self-assigned this Jul 2, 2024
@github-actions github-actions bot added the size/s label Jul 2, 2024
@github-actions github-actions bot added size/m and removed size/s labels Jul 3, 2024
@github-actions github-actions bot added size/s and removed size/m labels Jul 3, 2024
@github-actions github-actions bot added size/l and removed size/s labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant