New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CS-136 - Dependency updates to bring in latest profile change (commas on location) #78

Merged

mdyoung3 merged 3 commits into 5.x from CS-136-commas-to-location

Nov 11, 2024

Contributor

mdyoung3 commented Nov 8, 2024 •

edited

Loading

READY FOR REVIEW

Summary

Brings in latest change from Cardinal Service Profile
Dependency update
Ticket: https://stanfordits.atlassian.net/browse/CS-136

Review By (Date)

When does this need to be reviewed by?

Urgency

How critical is this PR?

Steps to Test

Do this
Then this
Then this

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

See Also

PR Checklist


          Dependency updates

github-actions bot added the size/m label

mdyoung3 changed the title ~~Dependency updates~~ Dependency updates to bring in latest profile change (commas on location)

mdyoung3 requested a review from pookmish

November 8, 2024 18:00

mdyoung3 changed the title ~~Dependency updates to bring in latest profile change (commas on location)~~ CS-136 - Dependency updates to bring in latest profile change (commas on location)

Contributor

pookmish commented Nov 8, 2024

Can you run composer update su-sws/* one more time. I just created a release for stanford_profile_helper

Contributor

pookmish commented Nov 8, 2024

Also, require the dev version of node_revision delete to avoid issues. composer require drupal/node_revision_delete:2.0.x-dev

mdyoung3 added 2 commits

November 8, 2024 14:56


          Update dependencies

a940565


          removed ddev testing yaml.

15d3ed2

Contributor Author

mdyoung3 commented Nov 8, 2024

pookmish approved these changes

View reviewed changes

Contributor

pookmish left a comment

GTG

mdyoung3 merged commit 4d63752 into 5.x

7 checks passed

mdyoung3 deleted the CS-136-commas-to-location branch

November 11, 2024 23:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels